chore(docs): update of OEL images - #2700
Open
ory-bot wants to merge 2 commits into
Open
Conversation
📝 WalkthroughWalkthroughThe PR adds OEL v26.3.5 and v26.3.6 changelogs for multiple components. It also updates Hydra, Keto, Kratos, Oathkeeper, and Polis image-tag tables with the corresponding release tags and dates. ChangesOEL release documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/self-hosted/oel/oathkeeper/changelog/v26.3.6.md`:
- Around line 8-15: Update both Oathkeeper documentation links in the changelog
to valid, non-404 guide URLs, preserving their respective references to request
path security and X-Forwarded headers.
In `@docs/self-hosted/oel/polis/changelog/v26.3.6.md`:
- Around line 47-49: Update the changelog’s description of the previous SAML
validation behavior to consistently exclude IPv6 unique-local literals from the
statements about allowed addresses. Adjust the “every IPv6 literal” wording at
docs/self-hosted/oel/polis/changelog/v26.3.6.md lines 47-49 and the “every
non-RFC1918 address” wording at lines 64-67, without changing the intended
allow/deny set.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0ceb5f78-5d4d-4f6d-9433-0ca7d7e6ed5f
📒 Files selected for processing (10)
docs/self-hosted/oel/keto/changelog/v26.3.6.mddocs/self-hosted/oel/kratos/changelog/v26.3.6.mddocs/self-hosted/oel/oathkeeper/changelog/v26.3.6.mddocs/self-hosted/oel/oauth2/changelog/v26.3.6.mddocs/self-hosted/oel/oel-hydra-image-tags.mddocs/self-hosted/oel/oel-keto-image-tags.mddocs/self-hosted/oel/oel-kratos-image-tags.mddocs/self-hosted/oel/oel-oathkeeper-image-tags.mddocs/self-hosted/oel/oel-polis-image-tags.mddocs/self-hosted/oel/polis/changelog/v26.3.6.md
🚧 Files skipped from review as they are similar to previous changes (5)
- docs/self-hosted/oel/oel-keto-image-tags.md
- docs/self-hosted/oel/oel-hydra-image-tags.md
- docs/self-hosted/oel/oel-polis-image-tags.md
- docs/self-hosted/oel/oel-kratos-image-tags.md
- docs/self-hosted/oel/oel-oathkeeper-image-tags.md
Comment on lines
+8
to
+15
| Read [Request path normalization and validation](https://www.ory.com/docs/oathkeeper/guides/request-path-security) if you run | ||
| Oathkeeper as a Decision API, place it behind another proxy, or rely on unusual path encodings. | ||
|
|
||
| #### Breaking changes | ||
|
|
||
| The Access Control Decision API no longer trusts incoming `X-Forwarded-*` headers by default. ForwardAuth-style integrations | ||
| (Traefik, NGINX, Ambassador, Envoy) must set `security.decision.x_forwarded_headers: trust` to keep working. See the | ||
| [documentation](https://www.ory.com/docs/oathkeeper/guides/request-path-security#x-forwarded-headers) for details. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Repair the Oathkeeper documentation links.
Both links point to a page that currently returns 404. Replace them with a valid guide URL or publish the referenced page before merging. ()
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/self-hosted/oel/oathkeeper/changelog/v26.3.6.md` around lines 8 - 15,
Update both Oathkeeper documentation links in the changelog to valid, non-404
guide URLs, preserving their respective references to request path security and
X-Forwarded headers.
Source: MCP tools
Comment on lines
+47
to
+49
| The previous check only rejected RFC1918 private IPv4 literals and IPv6 unique-local literals. It let through loopback, link-local | ||
| (including the cloud metadata address `169.254.169.254`), carrier-grade NAT, reserved and unspecified addresses, every IPv6 | ||
| literal, and every DNS hostname, and the fetch followed HTTP redirects without re-validating the target. A caller with an SSO |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Make the previous SAML validation behavior consistent.
The text says the previous check rejected IPv6 unique-local literals, then says it allowed every IPv6 literal and every non-RFC1918 address. Qualify both statements to exclude IPv6 unique-local literals, or describe the previous allow/deny set once and reuse it.
docs/self-hosted/oel/polis/changelog/v26.3.6.md#L47-L49: Correct “every IPv6 literal.”docs/self-hosted/oel/polis/changelog/v26.3.6.md#L64-L67: Correct “every non-RFC1918 address.”
📍 Affects 1 file
docs/self-hosted/oel/polis/changelog/v26.3.6.md#L47-L49(this comment)docs/self-hosted/oel/polis/changelog/v26.3.6.md#L64-L67
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/self-hosted/oel/polis/changelog/v26.3.6.md` around lines 47 - 49, Update
the changelog’s description of the previous SAML validation behavior to
consistently exclude IPv6 unique-local literals from the statements about
allowed addresses. Adjust the “every IPv6 literal” wording at
docs/self-hosted/oel/polis/changelog/v26.3.6.md lines 47-49 and the “every
non-RFC1918 address” wording at lines 64-67, without changing the intended
allow/deny set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update OEL images
Summary by CodeRabbit